From 886e1d1d2bd3a62314ef7d40c5e14f7b09b09f7c Mon Sep 17 00:00:00 2001 From: David Ball Date: Tue, 20 Aug 2024 04:13:13 -0400 Subject: [PATCH] fix: Problems in SignHelper were preventing the API client from working because of exports variable that wasn't adapted to TypeScript earlier. --- package-lock.json | 4 ++-- package.json | 2 +- src/auth/SignHelper.mts | 11 +++++------ 3 files changed, 8 insertions(+), 9 deletions(-) diff --git a/package-lock.json b/package-lock.json index c56b335..a94360c 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "amazon-pa-api5-node-ts", - "version": "2.2.7", + "version": "2.3.0", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "amazon-pa-api5-node-ts", - "version": "2.2.7", + "version": "2.3.0", "license": "Apache-2.0", "dependencies": { "superagent": "^9.0.0" diff --git a/package.json b/package.json index b3f399b..8c9022f 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "amazon-pa-api5-node-ts", - "version": "2.2.7", + "version": "2.3.0", "description": "ProductAdvertisingAPI 5.0 NodeJS SDK rewritten in TypeScript.", "license": "Apache-2.0", "main": "dist/src/index.mjs", diff --git a/src/auth/SignHelper.mts b/src/auth/SignHelper.mts index 72bf6bd..13a3780 100644 --- a/src/auth/SignHelper.mts +++ b/src/auth/SignHelper.mts @@ -48,18 +48,17 @@ const hexEncodedHash = (data: BinaryLike | string) => { return hashSHA256.digest(HEX).toString(); } - export const createAuthorizationHeaders = (timestamp: number | string | Date, accessKey: string, region: string, service: string, signedHeaders: string, signature: string) => - `${AWS4_HMAC_SHA256} Credential=${accessKey}/${exports.createCredentialScope(timestamp, region, service)}, SignedHeaders=${signedHeaders}, Signature=${signature}`; + `${AWS4_HMAC_SHA256} Credential=${accessKey}/${createCredentialScope(timestamp, region, service)}, SignedHeaders=${signedHeaders}, Signature=${signature}`; export const createCanonicalRequest = (method: string, pathname: string, query: Record, headers: Record, payload: any) => { var payloadJson = JSON.stringify(payload); return [ method.toUpperCase(), pathname, - exports.createCanonicalQueryString(query), - exports.createCanonicalHeaders(headers), - exports.createSignedHeaders(headers), + createCanonicalQueryString(query), + createCanonicalHeaders(headers), + createSignedHeaders(headers), hexEncodedHash(String(payloadJson)) ].join('\n'); }; @@ -96,7 +95,7 @@ export const createStringToSign = (time: number | string | Date, region: string, [ AWS4_HMAC_SHA256, toTime(time), - exports.createCredentialScope(time, region, service), + createCredentialScope(time, region, service), hexEncodedHash(request) ].join('\n');